handle python 3.12.1 change to skip behavior#100
Merged
swryan merged 3 commits intoOpenMDAO:masterfrom Dec 28, 2023
Merged
Conversation
crecine
approved these changes
Dec 28, 2023
crecine
left a comment
crecine
left a comment
There was a problem hiding this comment.
Pulling in the changes to my local environment fixed the issue with skipped tests causing failures: #99 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As of Python 3.12.1, startTest is not called before processing skips, so we
will add the test to our list without calling the super() startTest method
Related Issues
Backwards incompatibilities
None
New Dependencies
None