added current directory to sys.path during try_import to avoid any relative import failures in test files#118
Merged
swryan merged 1 commit intoOpenMDAO:masterfrom Jul 24, 2024
Conversation
…lative import failures in test files
swryan
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aviary team ran into an issue where all tests in a file were being skipped because they were attempting to do a relative import of a builder file at file scope and the import was failing because the local directory was not part of sys.path at the time when the test module was first imported (during test discovery).
Backwards incompatibilities
None
New Dependencies
None