Skip to content

M #-: [OneKE] Update ONEAPP_K8S_NO_PROXY default + add cluster/service CIDRs#125

Merged
sk4zuzu merged 3 commits intomasterfrom
f-#/oneke-modify-no-proxy-parameter
Mar 17, 2025
Merged

M #-: [OneKE] Update ONEAPP_K8S_NO_PROXY default + add cluster/service CIDRs#125
sk4zuzu merged 3 commits intomasterfrom
f-#/oneke-modify-no-proxy-parameter

Conversation

@aleixrm
Copy link
Contributor

@aleixrm aleixrm commented Mar 6, 2025

We have detected that users are copying directly the exposed default values in the template, and this is causing failures, as $ONEAPP_RKE2_SUPERVISOR_EP $ONEAPP_K8S_CONTROL_PLANE_EP are not expanded when used as input (in the documentation are expressing a reference to those parameter values).

@aleixrm aleixrm requested review from jaimecb, rsmontero and sk4zuzu March 6, 2025 08:12
Copy link
Contributor

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleixrm pls update the version: as well 👍.

Signed-off-by: Aleix Ramírez <aramirez@opennebula.io>
@aleixrm aleixrm force-pushed the f-#/oneke-modify-no-proxy-parameter branch from 3d37ba4 to 5dca1d6 Compare March 11, 2025 08:29
@aleixrm aleixrm requested a review from sk4zuzu March 11, 2025 08:29
@aleixrm aleixrm marked this pull request as draft March 11, 2025 15:16
@aleixrm
Copy link
Contributor Author

aleixrm commented Mar 11, 2025

Waiting to correct oneke appliances versions from 6.10.0-2 to 6.10.0-3 in another PR

- Add ONEAPPS_K8S_CLUSTER_CIDR parameter
- Cleanup yaml syntax
@sk4zuzu sk4zuzu force-pushed the f-#/oneke-modify-no-proxy-parameter branch from 7a33ee6 to 1a8be5e Compare March 13, 2025 20:13
@sk4zuzu sk4zuzu changed the title M #-: [OneKE] Deletes confusing default values in ONEAPP_K8S_NO_PROXY M #-: [OneKE] Update ONEAPP_K8S_NO_PROXY default + add cluster/service CIDRs Mar 13, 2025
@sk4zuzu sk4zuzu marked this pull request as ready for review March 17, 2025 14:34
@sk4zuzu sk4zuzu merged commit 7ff55cf into master Mar 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants