refactor!: Remove calculated values from Interfaces (Fix #64)#66
Merged
dietmarw merged 3 commits intoDec 21, 2025
Merged
Conversation
Replaces image with improved SVG version
…ontact OpenHPL.Waterway and OpenHPL.ElectroMech.Turbines models are updated - Simple model is checked and verified.
Collaborator
|
Thanks @pandeysudan1. I have not forgotten about this, just not had the time to go through this thoroughly. |
Contributor
Author
Thanks for the reply @dietmarw |
dietmarw
reviewed
Dec 18, 2025
dietmarw-se
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #64: “Interfaces should not contain calculated values”.
Changes
ContactPortandContactNodefrom Interfaces so that variables and relations are defined explicitly inside the device modelTwoContactis now namedTwoContactsContactPortand `ContactNode'.Please let me know if you find anything that needs to be updated.
Thanks.