Feat: Update handling of diverging or converging pipe.#69
Merged
Conversation
dietmarw
force-pushed
the
bb_small_change_01
branch
from
35bdae0 to
a8c932a
Compare
ref: #63 This extends the simple pipe momentum equation to include a local loss term F_taper = K_c · (ρ·v_o^2/2)·A_o for the diameter contraction. Adjust K_c based on your taper geometry: 0.05–0.15 for gentle cones, up to 0.6 for sharp contractions.
WORK IN PROGRESS - NOT YET COMPLETE
ref: #63 This extends the simple pipe momentum equation to include a local loss term F_taper = K_c · (ρ·v_o^2/2)·A_o for the diameter contraction. Adjust K_c based on your taper geometry: 0.05–0.15 for gentle cones, up to 0.6 for sharp contractions.
WORK IN PROGRESS - NOT YET COMPLETE
dietmarw
force-pushed
the
bb_small_change_01
branch
from
6c44e00 to
e5fb5fc
Compare
dietmarw
previously requested changes
Feb 2, 2026
| Waterway.Reservoir Upstream(h_0 = 89.67, constantLevel=true) | ||
| annotation( | ||
| Placement(transformation(origin={-50,0}, extent={{-10,-10},{10,10}}))); | ||
| Waterway.Reservoir Downstream(h_0 = -10.33, constantLevel=true) |
Collaborator
There was a problem hiding this comment.
Since we now can set the pressure reference to gauge pressure. Would it not be a good idea to use that also in this example?
Collaborator
|
Thanks, it's nice to see this fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63
Update the handling of pipes with different inlet and outlet diameter.