feat: BaseValve and Turbine update to aviod p_a=0 issues and non-linear closing law.#70
Merged
Merged
Conversation
boerrebj
changed the title
dietmarw
approved these changes
Feb 2, 2026
Collaborator
dietmarw
left a comment
dietmarw
left a comment
There was a problem hiding this comment.
Thanks, I've did some additional code clean up but no functional change so this is goot to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BaseValve model has been updated to make it more robust and added functionaligy:
The Turbine model has been updated with specifying smoothness and exterpolation requirements in look_up_table.