fix!: Correct the speed in and outputs of the base class for turbine, generator and grid#71
Merged
Merged
Conversation
dietmarw
changed the title
dietmarw
force-pushed
the
feat/pu-speeds
branch
from
b16ce3c to
9810616
Compare
dietmarw
changed the title
The only non-pu signal is the w output which is the real mechanical angular velocity
dietmarw
force-pushed
the
feat/pu-speeds
branch
from
9810616 to
60021b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was confusing what was in Hz, what in rad/s (mechanical, synchronous?) and what in pu. This also let to a wrongly calculated output "frequency" signal.
It has been now fixed in a way that the speed(frequency) in and outputs and initial values are always in pu. The only non-pu output is the optional "w" connector which represents the real mechanical angular velocity.