Fixed Integration Test Workflow#265
Merged
JamesMGreene merged 1 commit intoJul 26, 2022
Merged
Conversation
Signed-off-by: Param Siddharth <contact@paramsid.com>
Contributor
|
Please remove me from the email list.
Thank you,
Joe
…On Mon, Jul 25, 2022 at 7:12 AM Param Siddharth ***@***.***> wrote:
@paramsiddharth <https://github.com/paramsiddharth> requested review from
@ProgramEquity/dev-leads on: #265
<#265> Fixed Integration
Test Workflow as a code owner.
—
Reply to this email directly, view it on GitHub
<#265 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY44P3T5PH3BLBIRKHQSESDVVZZADANCNFSM54R4GZJA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Joseph Varner
Firehawk Digital
(937) - 805 - 9270
|
JamesMGreene
approved these changes
Jul 26, 2022
Contributor
JamesMGreene
left a comment
JamesMGreene
left a comment
There was a problem hiding this comment.
Makes sense. 👍🏻 Thanks for investigating. 💝
Contributor
|
P.S. @joester030376 I have removed you from the ProgramEquity organization. |
Contributor
|
Thank you.
Joe
…On Tue, Jul 26, 2022 at 10:59 AM James M. Greene ***@***.***> wrote:
P.S. @joester030376 <https://github.com/joester030376> I have removed you
from the ProgramEquity organization.
cc @manishapriya94 <https://github.com/manishapriya94>
—
Reply to this email directly, view it on GitHub
<#265 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY44P3RS3PKTAYAGQC4KBJLVV74OVANCNFSM54R4GZJA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Joseph Varner
Firehawk Digital
(937) - 805 - 9270
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Integration Test Workflow
This PR fixes the integration test bug that originated after the introduction of Stripe in the app.
Before merging, a point needs to be addressed below. Please read the description thoroughly.
Resolves #263.
Proof of Concept
The changes resulted in a successful run on my personal fork (with all the secrets properly configured): Workflow Run
Additionally, I had to remove line 17 to get it to work on my fork, because the condition doesn't allow the workflow to run on forks.
... jobs: test: - if: ${{ github.repository == 'ProgramEquity/amplify' }} runs-on: ubuntu-latest timeout-minutes: 5 ...The change was made in a different branch than the head for this PR, so we don't need to worry about it.
Instructions
TEST_STRIPE_SECRET_KEY: Set it to the Stripe test key that we are using for the app.You can copy it from your Codespaces environment.
Once the secret is added, the PR may successfully be merged.
Note
Once this PR is merged, other PRs having a false negative for the integration tests will no longer occur. Hence, you're encouraged to merge it as soon as possible.
Signed-off-by: Param Siddharth contact@paramsid.com