feat: implement Minecraft-like cloud system

[MichaelFisher1997]

Summary

• Implements a Minecraft-style blocky cloud system at a fixed altitude (default: 160).
• Clouds move naturally with a wind system and integrate with sun/moon lighting and color tints.
• Adds fake moving cloud shadows on the terrain using noise projection.
• Ensures proper mountain occlusion and altitude-based fading for flying.

[MichaelFisher1997]

/oc can you do a indepth code review of this PR

[opencode-agent]

Final Code Review Summary

Overall Assessment: Good Implementation with Minor Issues

The cloud system implementation is well-designed and follows the specification closely. It demonstrates good architectural decisions and proper integration with the existing engine.

Key Strengths ✅

1. Excellent Documentation: Comprehensive specification with clear goals and constraints
2. Proper Architecture: Clean struct design following Zig patterns
3. Good Integration: Seamless integration with atmosphere, renderer, and input systems
4. Performance Conscious: Single draw call, efficient shaders, proper depth testing
5. Good Shadow System: Well-implemented fake cloud shadows with proper sun projection
6. Consistent Style: Follows existing codebase conventions and patterns

Critical Issues to Address ❌

1. Error Handling: Silent shader failure could cause runtime crashes
2. API Inconsistency: initCloudShader() return type mismatch
3. Resource Management: Missing error handling in OpenGL cleanup

Minor Issues ⚠️

1. Magic Numbers: Hardcoded cloud mesh size should be configurable
2. Shader Optimization: Could benefit from performance improvements
3. Documentation: Markdown formatting issue in specification

Recommendations

High Priority:

1. Fix error handling in cloud initialization
2. Fix API consistency issues
3. Add proper error propagation

Medium Priority:

1. Make cloud mesh size configurable
2. Optimize shader performance
3. Add performance monitoring

Low Priority:

1. Fix markdown formatting
2. Add cloud-specific debug UI controls

Conclusion

This is a solid implementation that successfully adds a Minecraft-style cloud system to the voxel engine. The core functionality works well, and the integration with existing systems is clean. The main issues are in error handling and API consistency, which are important for production stability but don't affect the basic functionality.

The implementation successfully achieves the goals outlined in the specification:

• ✅ Visually readable clouds at all altitudes
• ✅ Natural wind movement
• ✅ Time-of-day integration
• ✅ Minimal performance impact
• ✅ No coupling to terrain logic

Recommendation: APPROVE with required fixes for error handling and API consistency before merging.

opencode session  |  github run