Skip to content

Add pre-commit configuration file#259

Merged
Hop311 merged 1 commit into
masterfrom
add/pre-commit
Mar 13, 2025
Merged

Add pre-commit configuration file#259
Hop311 merged 1 commit into
masterfrom
add/pre-commit

Conversation

@Spartan322
Copy link
Copy Markdown
Member

Add codespell checks and corrections
Add static check github action

@Spartan322 Spartan322 added the enhancement New feature or request label Dec 23, 2024
Comment thread src/openvic-simulation/dataloader/Dataloader.hpp
@wvpm
Copy link
Copy Markdown
Contributor

wvpm commented Jan 30, 2025

Strange how it doesn't care about mobilisation_size and mobilization_impact.

@Spartan322
Copy link
Copy Markdown
Member Author

Pretty sure mobilisation_size and mobilization_impact are both correct when using standard en locale.

wvpm
wvpm previously approved these changes Feb 14, 2025
Copy link
Copy Markdown
Contributor

@wvpm wvpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure enum spelling corrections don't introduce breaking changes.

@Spartan322 Spartan322 force-pushed the add/pre-commit branch 4 times, most recently from 72572e2 to dfb6449 Compare March 11, 2025 11:51
wvpm
wvpm previously approved these changes Mar 11, 2025
Comment thread src/openvic-simulation/modifier/ModifierManager.cpp Outdated
@Spartan322 Spartan322 force-pushed the add/pre-commit branch 2 times, most recently from 14ed3f8 to f2d1150 Compare March 12, 2025 19:43
Comment thread src/openvic-simulation/GameManager.cpp Outdated
Comment thread src/openvic-simulation/dataloader/Dataloader.hpp
Hop311
Hop311 previously approved these changes Mar 12, 2025
Add typos checks and corrections
Add static check github action
@Hop311 Hop311 merged commit 164c382 into master Mar 13, 2025
@Spartan322 Spartan322 deleted the add/pre-commit branch March 13, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants