Split containers hpp#731

Merged

wvpm merged 1 commit into

split-containers-hpp

May 18, 2026

Contributor

wvpm commented May 14, 2026 •

edited by Spartan322

Loading

~~Stacked on top of Minimise fixed point header #721~~
Inspired by Move generic containers into core/containers #693

Goal: reduce header imports leaking everywhere
Method: split up Containers.hpp into minimal headers and update consumers

wvpm requested a review from a team as a code owner

May 14, 2026 13:06

wvpm added enhancement topic:core topic:codestyle labels

wvpm force-pushed the split-containers-hpp branch 2 times, most recently from 5ab1243 to a06fb48 Compare

May 14, 2026 13:26

wvpm marked this pull request as draft

May 14, 2026 13:45

wvpm changed the base branch from master to minimise_fp_header

May 14, 2026 13:48

wvpm force-pushed the split-containers-hpp branch from a06fb48 to 53584d4 Compare

May 14, 2026 18:19

wvpm force-pushed the minimise_fp_header branch from 219a80d to 3f32a55 Compare

May 14, 2026 23:08

wvpm force-pushed the split-containers-hpp branch 2 times, most recently from 6130c5a to 73b5eb3 Compare

May 14, 2026 23:18

wvpm force-pushed the minimise_fp_header branch 6 times, most recently from 2674f03 to f3a283b Compare

May 17, 2026 11:20

Base automatically changed from minimise_fp_header to master

May 17, 2026 11:34

wvpm force-pushed the split-containers-hpp branch from 73b5eb3 to c3b20a2 Compare

May 17, 2026 11:47

wvpm marked this pull request as ready for review

May 17, 2026 11:47

wvpm enabled auto-merge

May 17, 2026 11:57

wvpm disabled auto-merge

May 17, 2026 11:57

wvpm force-pushed the split-containers-hpp branch from c3b20a2 to 5f1d368 Compare

May 17, 2026 11:59

wvpm enabled auto-merge

May 17, 2026 11:59

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/allocators/Deleter.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/allocators/NewAllocator.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/Colony.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/CowPtr.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/CowVector.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/Deque.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/Formatting.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/Formatting.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/make_tracked_allocator.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/Queue.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/SmartPtr.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/SmartPtr.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/String.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/StringStream.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/Vector.hpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/types/Signal.hpp

wvpm force-pushed the split-containers-hpp branch 2 times, most recently from bead4a0 to 93ed86c Compare

May 18, 2026 11:14

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/core/memory/CowVector.hpp Outdated

wvpm force-pushed the split-containers-hpp branch from 93ed86c to c047918 Compare

May 18, 2026 12:39

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/console/ConsoleInstance.cpp Outdated

Spartan322 reviewed

View reviewed changes

src/openvic-simulation/GameManager.cpp Outdated


          Split up Containers.hpp and move to core/memory/

caf1082

wvpm force-pushed the split-containers-hpp branch from c047918 to caf1082 Compare

May 18, 2026 14:02

Spartan322 approved these changes

View reviewed changes

wvpm merged commit bbdafc0 into master

16 checks passed

wvpm deleted the split-containers-hpp branch

May 18, 2026 14:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement topic:codestyle topic:core