Accept truncations in pops smaller than 16#740
Merged
Conversation
schombert
reviewed
May 19, 2026
wvpm
force-pushed
the
accept_small_pop_truncation
branch
from
98ca0ae to
0402f32
Compare
Spartan322
reviewed
May 19, 2026
wvpm
force-pushed
the
accept_small_pop_truncation
branch
from
0402f32 to
368d1fa
Compare
Spartan322
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncations are bound to happen with fixed point math. At a certain pop size we just have to accept it to avoid spamming warnings.