Tolerate concurrent creation of directories#506
Merged
Conversation
When two processes both decide a directory needs to be created (e.g. multiple JRuby instances in openvox-server independently bootstrapping Puppet settings against the same confdir), Dir.mkdir raises Errno::EEXIST for whichever one loses the race, surfacing as a resource failure even though the desired state was actually achieved. Treat EEXIST as success when the path is now a directory, while still raising for a genuine conflict (e.g. a file or symlink already at that path). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
Member
Author
|
This is one half of a fix for random test failures that have been plaguing OpenVox Server. See OpenVoxProject/openvox-server#414 |
bastelfreak
approved these changes
Jul 1, 2026
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
When two processes both decide a directory needs to be created (e.g. multiple JRuby instances in openvox-server independently bootstrapping Puppet settings against the same confdir), Dir.mkdir raises Errno::EEXIST for whichever one loses the race, surfacing as a resource failure even though the desired state was actually achieved. Treat EEXIST as success when the path is now a directory, while still raising for a genuine conflict (e.g. a file or symlink already at that path).
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent