Skip to content

feat: New logic for controls visibility#446

Merged
MakinoharaShoko merged 1 commit into
OpenWebGAL:devfrom
tinyAdapter:dev
Jan 14, 2024
Merged

feat: New logic for controls visibility#446
MakinoharaShoko merged 1 commit into
OpenWebGAL:devfrom
tinyAdapter:dev

Conversation

@tinyAdapter
Copy link
Copy Markdown
Member

Fix #433

return true;
}

const isText = stageState.showText !== '' || stageState.showName !== '';
Copy link
Copy Markdown
Member Author

@tinyAdapter tinyAdapter Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 isText 和下面的 isInIntro 都是一些没有被 Redux 捕获的状态

const isText = stageState.showText !== '' || stageState.showName !== '';

introContainer.style.display = 'block';

我建议把这些状态用 Redux 表示,不然之后可能遇到类似的检查又要 copy/paste

@MakinoharaShoko MakinoharaShoko merged commit 4a67dc5 into OpenWebGAL:dev Jan 14, 2024
MakinoharaShoko added a commit to ClodLingxi/WebGAL that referenced this pull request Dec 20, 2024
feat: New logic for controls visibility
KonshinHaoshin pushed a commit to KonshinHaoshin/WebGAL_Eastmount that referenced this pull request Nov 7, 2025
feat: New logic for controls visibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants