Skip to content

fix (language) auto-detect and auto-load relevant language files during CMP initialization#48

Merged
potench merged 4 commits into
masterfrom
potench/2.1.1
Sep 30, 2020
Merged

fix (language) auto-detect and auto-load relevant language files during CMP initialization#48
potench merged 4 commits into
masterfrom
potench/2.1.1

Conversation

@potench
Copy link
Copy Markdown

@potench potench commented Sep 30, 2020

Fix

  • auto-detect config.language and auto-load relevant language files during CMP initialization
  • configurable config.theme.maxWidthModal

Test Plan

Automatic Detection

  1. chrome://settings, search for "language", change your default language from "english" to "sweedish"
  2. yarn dev
  3. go to http://localhost:8080/tcf-2.0.html
  4. See browser language reflected in CMP.

Force Language

  1. change config.language to "it", reload, see CMP display in Italian

Fallback to en

  1. change config.language to "test", reload, see CMP display in english.

@potench potench merged commit 7f1b91d into master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant