potench/upgrade cmp 0.0.1#5
Merged
Merged
Conversation
Add gdprAppliesGlobally flag as independent config property
Truncate metadata string to match spec
Update a couple dependencies
| by pubvendors.json. | ||
| </span> | ||
| </span> | ||
| <span class={style.argument}> |
There was a problem hiding this comment.
why is the spacing so large in these files?
There was a problem hiding this comment.
nvm it's an upstream merge i see
Author
There was a problem hiding this comment.
project is using tabs I guess this is how github renders the tabs, indentation looks right on my IDE though
Author
There was a problem hiding this comment.
also, even if it's not conforming to our standard, i'd leave this as is so it's easier to manage upstream changes in the cmp (trying to touch as little of the core of the project as possible)
danielrussellLA
approved these changes
Aug 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Test Plan