Skip to content

package dependencies are not minimal #10

@ebrahimebrahim

Description

@ebrahimebrahim

The package dependencies that we list are not minimal. Things are included that are not really needed to install and use the openlifu package itself but only needed for other purposes such as running example notebooks or generating documentation.

https://github.com/OpenwaterHealth/OpenLIFU-python/blob/46d73e8d70886911890a8e20351ea15d27ed8460/pyproject.toml#L5-L18

  • We should pare down this list to only the essentials.
  • Dependencies needed for running example notebooks can be put somewhere else like a requirements.txt inside the notebook directory, or even just notebook code cells with a !pip install in them.
  • Dependencies needed for generating documentation, running tests, running linting, etc. can be put into their own groups of optional dependencies. (This part should be done as part of the resolution of add CI/CD workflows for publishing, linting, testing, and documentation generation #5 rather than being associated with the present issue.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions