[do not merge] Temporary branch to test S#124#139
Closed
ebrahimebrahim wants to merge 21 commits into
Closed
Conversation
This includes * changing Solution.focus to Solution.foci and making that be a *list* of Points rather than a Point. * changing the xarray simulation data to have an additional coord "focal_point_index" * adding an axis to the delay and apodization arrays in Solution to index focal points.
This adds minimal solution analysis code so it outputs at least the `mainlobe_pnp_MPa` attribute. The rest has been commented out for future work, additionnal modules/functions are also added to prepare future work.
Fix circular import issue Co-authored-by: Ebrahim Ebrahim <ebrahim.ebrahim@kitware.com>
distance units now available in SolutionOptions
Removed `calc_dist_from_focus`, the algorithm is now in `mask_focus` pre-commit hook
…_to_test_S#124 This was a nontrivial merge!
Collaborator
Author
ebrahimebrahim
force-pushed
the
temporary_branch_to_test_S#124
branch
from
1b1e3c4 to
0374c53
Compare
This is just an example of how Protocol.calc_solution could work. The real thing should be ported over from the matlab code. The purpose of this example is to show the API we need from the side of SlicerOpenLIFU.
ebrahimebrahim
force-pushed
the
temporary_branch_to_test_S#124
branch
from
0374c53 to
0ef7176
Compare
* automatically create empty `runs.json`, `solutions.json`, and `volumes.json` when new objects are written to the database that should have those * update our example data in dvc to have these empty solutions.json, etc. files
… into temporary_branch_to_test_S#124
Collaborator
Author
|
This is no longer needed since #146 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary branch created just to test OpenwaterHealth/SlicerOpenLIFU#124 until the needed functionality is ported from the matlab codebase (#104 and #126)
This PR is meant to be used for reference and then closed without merging.
The important thing to reference here in this branch is
Protocol.calc_solution. This shows the API that we will assume from SlicerOpenLIFU