Drop Python3.9 and bump kwave to v0.4.0 (#399)#410
Conversation
ebrahimebrahim
force-pushed
the
399-drop-python-39-support-and-upgrade-kwave
branch
from
eef0755 to
a9c8fed
Compare
Pin numpy<2 for compatibility with onnxruntime 1.18.0, which was compiled against NumPy 1.x and fails to import with NumPy 2.x. onnxruntime is pinned to 1.18.0 due to Windows DLL issues in newer versions (see #309).
ebrahimebrahim
force-pushed
the
399-drop-python-39-support-and-upgrade-kwave
branch
from
a9c8fed to
b22640e
Compare
It seems to be a bug in kwave that causes this warning to be raised even when the binary name is correct. It shouldn't affect usage.
|
@sadhana-r It is a very small PR; it just looks big because one commit has to do a style change to drop a the python 3.9 way of doing type unions. I think you said you already tested kwave 0.4.0 in the custom app and had no issues right? One of us should try this specific branch in the slicer 5.10 version of the custom app and make sure there are no problems: I will do it if I get to it first! |
|
@sadhana-r Alright I tested a workflow in the app. Nothing wrong up through computing a sonication solution. I tested by building the custom app from OpenwaterHealth/openlifu-desktop-application#70 and then installing this branch of OpenLIFU-python into the app. So no need for you to test; just code review the two small non-style commits here. |
sadhana-r
left a comment
sadhana-r
left a comment
There was a problem hiding this comment.
Code changes look good to me! And yes, I also tested kwave v0.4.0 and didn't have any issues!
2 participants
This also pins numpy to <2 to maintain compatibility with onnx==1.18.0, which was needed due to #309 (and #309 may still be affecting some users).