changed PropTypes reference#1
Open
truca wants to merge 1 commit into
Open
Conversation
adrienthiery
suggested changes
Jan 22, 2018
Contributor
There was a problem hiding this comment.
Hi @truca ,
Thanks a lot for the PR ! (and sorry for the delay)
I had just a few comments on the PR, if you wouldn't mind correcting them, I'll merge the PR right away after.
Thanks a lot for contributing :)
| TouchableHighlight, | ||
| View, | ||
| } from 'react-native'; | ||
| import PropTypes from 'prop-types' |
Contributor
There was a problem hiding this comment.
Would you mind adding a ; at the end to keep up with the linting rules please?
| touchableContainerStyle: View.propTypes.style, | ||
| underlayColor: React.PropTypes.string, | ||
| uppercase: React.PropTypes.bool, | ||
| containerStyle: PropTypes.style, |
Contributor
There was a problem hiding this comment.
Please use ViewPropTypes instead of PropTypes (react/react-native@53905a5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React package don't have proptypes property anymore, instead it is in another package, "prop-types". I added the dependency and used it.