[Places] Initial commit of places operating status - #354
Conversation
|
How does this fit in with confidence=0? |
Good question. This is something we should document carefully also. (Related: Are we still thinking about switching |
We're still debating on this one - for now we settled on setting confidence to 0 when it's also marked as closed to match the current confidence definition. From discussions happening - I think the confidence score will be redefined to indeed more like 'existence' to indicate whether the place ever existed or not, and used more to weed out junk vs real places (even places that are now closed, but used to exist) |
The Places TF this was actually discussed in great detail. First confidence = existence. There has been no further conversation to change the schema field name to existence. Basically documentation can explain that is our confidence in the existence of a place. Without this field we would drive the confidence to 0 as that is the only closure indicator that we had. Once we have this the confidence should be independent of the closure status. For example we could have an operating status of open and a very low confidence indicating that the place most likely does not exists. Or we can have an operating status of closed and a very high confidence indicating that we know the place is there but it is closed. |
I said it above, but "closed with confidence 0" sounds to me like "you are not confident it is closed". |
|
Seth Fitzsimmons (@mojodna) Jennings Anderson (@jenningsanderson) Jens Goossens (@jensgoossens-tomtom) This change will have to be ported to the Pydantic model. |
Seth Fitzsimmons (sethfitz)
left a comment
There was a problem hiding this comment.
Mostly mechanical changes, though we may want to consider how we think about what "default" means and how it manifests.
This is the Pydantic equivalent of #354
|
Pydantic equivalent here: #389 |
This is the Pydantic equivalent of #354
|
Looks like we will need to rebase / resolve these conflicts? |
Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com>
Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com>
Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com>
Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com>
5de846f
79dfa26 to
5de846f
Compare
This is the Pydantic equivalent of #354
This is the Pydantic equivalent of #354
This is the Pydantic equivalent of #354
* Initial commit of places operating status * Improve in-schema documentation for operating status * feat(OvertureMaps#383): update operating status values * feat(OvertureMaps#383): update example * feat(OvertureMaps#383): add doc to confidence behavior for closed places * feat(OvertureMaps#383): nit: add space after commas * Update counterexamples/places/bad-operating-status.yaml Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com> * Update examples/places/place-with-operating-status.yaml Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com> * Update examples/places/place-with-operating-status.yaml Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com> * Update counterexamples/places/bad-operating-status.yaml Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com> * add clarification * mark operating status as required and remove the default for clarity * fix test * fix more tests * Remove extra conflict >>>>>> --------- Co-authored-by: Jens Goossens <jens.goossens@tomtom.com> Co-authored-by: Jens Goossens <82045265+jensgoossens-tomtom@users.noreply.github.com> Co-authored-by: Seth Fitzsimmons <sethfitz@amazon.com>
Major change release plan
Minor release as its a new optional column
B. Related MINOR change steps
Add operating_status field
C. Public documentation and messaging plan
TODO.
Description
Brief description of the business purpose and effect of the pull request.
Allow Overture to include places that are known to be closed
Reference
List of relevant links to GitHub issues, PRs, and other documentation.
Testing
Added example and counterexample
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.