Fix up overture-schema-sources - #394
Merged
Merged
Conversation
Seth Fitzsimmons (sethfitz)
requested a review
from Victor Schappert (vcschapp)
October 1, 2025 21:55
Seth Fitzsimmons (sethfitz)
temporarily deployed
to
staging
October 1, 2025 21:55 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Seth Fitzsimmons (sethfitz)
temporarily deployed
to
staging
October 1, 2025 22:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Seth Fitzsimmons (sethfitz)
force-pushed
the
pydantic-sources-fixup
branch
from
October 1, 2025 22:56
205f2e0 to
c340f1e
Compare
Seth Fitzsimmons (sethfitz)
temporarily deployed
to
staging
October 1, 2025 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
- add support for models without a `type` field to the dynamic union generator in `overture.schema:parse`; it now produces `<discriminated union of models with 'type'> | <regular union of models without 'type'>` to maintain performance while adding flexibility for peripheral Overture models - remove non-existent `PatternPropertiesDictConstraint` in favor of `json_schema_extra=` kwarg - remove deprecated `format` kwargs (redundant with `HttpUri`) - avoid transforming non-Features to GeoJSON - add missing typing information - align YAML formatting with existing examples - add missing baseline sources JSON Schema
Seth Fitzsimmons (sethfitz)
force-pushed
the
pydantic-sources-fixup
branch
from
October 3, 2025 15:08
c340f1e to
22cd50a
Compare
Seth Fitzsimmons (sethfitz)
temporarily deployed
to
staging
October 3, 2025 15:08 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Victor Schappert (vcschapp)
approved these changes
Oct 3, 2025
Victor Schappert (vcschapp)
added a commit
that referenced
this pull request
Oct 3, 2025
This commit used to move "sources" out of the way for now, but that's over now after rebasing on Seth's #394.
Victor Schappert (vcschapp)
added a commit
that referenced
this pull request
Oct 3, 2025
Victor Schappert (vcschapp)
added a commit
that referenced
this pull request
Oct 3, 2025
This commit used to move "sources" out of the way for now, but that's over now after rebasing on Seth's #394.
Victor Schappert (vcschapp)
added a commit
that referenced
this pull request
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typefield to the dynamic union generator inoverture.schema:parse; it now produces<discriminated union of models with 'type'> | <regular union of models without 'type'>to maintain performance while adding flexibility for peripheral Overture modelsPatternPropertiesDictConstraintin favor ofjson_schema_extra=kwargformatkwargs (redundant withHttpUri)