[BUG] make install does not regenerate overture-schema-pyspark's codegen output - #580
Merged
Merged
Conversation
Seth Fitzsimmons (sethfitz)
temporarily deployed
to
staging
July 21, 2026 18:26 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
install only ran uv-sync, never generate-pyspark. The generated expressions and conformance tests under overture-schema-pyspark aren't tracked in git, so a fresh worktree following the documented init-worktree -> make install flow had neither: a plain pytest run afterward silently collected thousands fewer tests with no error to signal the gap. install now depends on generate-pyspark, matching what check and test-all already do. Closes #579. Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
Seth Fitzsimmons (sethfitz)
force-pushed
the
fix-install-pyspark-codegen
branch
from
July 21, 2026 18:28
a4cff17 to
7562b86
Compare
TristanDiet-TomTom
approved these changes
Jul 22, 2026
Victor Schappert (vcschapp)
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make installonly ranuv-sync, nevergenerate-pyspark. The generated PySpark expressions and conformance tests aren't tracked in git, so a fresh worktree following the documented check out ->make installflow ended up with neither.pytestrun afterward silently collected thousands fewer tests than the full suite, with no error to signal the gap -- discovered while verifying rebases of several other PRs against fresh worktrees.installnow depends ongenerate-pyspark, matching whatcheckandtest-allalready do.Closes #579.
Test plan
make install, confirmexpressions/generatedandtests/generatedare populated