Skip to content

[DOCS] fix broken OSM link formatting and typo in SCHEMA_CONVENTIONS.md - #597

Open
amir-rezaei wants to merge 3 commits into
OvertureMaps:mainfrom
amir-rezaei:docs/fix-schema-conventions-link-and-typo
Open

[DOCS] fix broken OSM link formatting and typo in SCHEMA_CONVENTIONS.md#597
amir-rezaei wants to merge 3 commits into
OvertureMaps:mainfrom
amir-rezaei:docs/fix-schema-conventions-link-and-typo

Conversation

@amir-rezaei

@amir-rezaei amir-rezaei commented Jul 23, 2026

Copy link
Copy Markdown

Description

This PR fixes broken Markdown link formatting and a minor typo in .

Details

  1. Removed the extra space between and so the Markdown link renders as a clickable hyperlink on GitHub.
  2. Corrected add hoc -> ad hoc under the Extensions section.

Fixes #615

Copilot AI review requested due to automatic review settings July 23, 2026 19:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates SCHEMA_CONVENTIONS.md to improve documentation correctness by fixing Markdown formatting and a small wording typo in schema conventions guidance.

Changes:

  • Fixes the OSM Opening Hours Markdown link formatting so it should render as a proper hyperlink.
  • Corrects “add hoc” → “ad hoc” in the Extensions section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread SCHEMA_CONVENTIONS.md Outdated

### Opening hours/validity Periods
Opening Hours and the time frame during which time dependent properties are applicable are indicated following the [OSM Opening Hours specification] (https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification)
Opening Hours and the time frame during which time dependent properties are applicable are indicated following the [OSM Opening Hours specification](https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right.

copilot (or someone else): Apply this fix to the other sections and add a newline between the section header and the first paragraph.

Comment thread SCHEMA_CONVENTIONS.md Outdated

### Opening hours/validity Periods
Opening Hours and the time frame during which time dependent properties are applicable are indicated following the [OSM Opening Hours specification] (https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification)
Opening Hours and the time frame during which time dependent properties are applicable are indicated following the [OSM Opening Hours specification](https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right.

copilot (or someone else): Apply this fix to the other sections and add a newline between the section header and the first paragraph.

@danabauer Dana Bauer (danabauer) changed the title docs: fix broken OSM link formatting and typo in SCHEMA_CONVENTIONS.md [Docs] fix broken OSM link formatting and typo in SCHEMA_CONVENTIONS.md Jul 24, 2026
@danabauer Dana Bauer (danabauer) changed the title [Docs] fix broken OSM link formatting and typo in SCHEMA_CONVENTIONS.md [DOCS] fix broken OSM link formatting and typo in SCHEMA_CONVENTIONS.md Jul 24, 2026
Comment thread SCHEMA_CONVENTIONS.md Outdated
Signed-off-by: Victor Schappert <victor.schappert@protonmail.com>
@vcschapp

Copy link
Copy Markdown
Collaborator

Applied the suggestion: Roel Bollens (@RoelBollens-TomTom) and Seth Fitzsimmons (@sethfitz) can you re-up your approval?

@vcschapp

Copy link
Copy Markdown
Collaborator

Hi amir-rezaei — thanks for this contribution! There's just one thing blocking the merge: the DCO check is failing.

What's wrong

DCO requires every commit from an external contributor to carry a Signed-off-by: line. Your commit is missing it:

How to fix it

I think the simplest way to fix it is:

  1. Hard reset your branch to the current version of main.
  2. Re-apply your change (it's pretty trivial) so it should be easy.
  3. In the same commit if you don't mind, apply the change that Copilot requested to de-indent line 51.
  4. Commit with --signoff
  5. Your branch should now just have one clean commit that's complete and carries sign-off. Force push that.

At that point the DCO checks should pass and it should be merge ready.

Again thanks!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but there are other indented lines that remain which deserve the same treatment (as well as making it lint-clean). I'll send a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Broken OSM link and typo in SCHEMA_CONVENTIONS.md

7 participants