[DOCS] fix broken OSM link formatting and typo in SCHEMA_CONVENTIONS.md - #597
[DOCS] fix broken OSM link formatting and typo in SCHEMA_CONVENTIONS.md#597amir-rezaei wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates SCHEMA_CONVENTIONS.md to improve documentation correctness by fixing Markdown formatting and a small wording typo in schema conventions guidance.
Changes:
- Fixes the OSM Opening Hours Markdown link formatting so it should render as a proper hyperlink.
- Corrects “add hoc” → “ad hoc” in the Extensions section.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Opening hours/validity Periods | ||
| Opening Hours and the time frame during which time dependent properties are applicable are indicated following the [OSM Opening Hours specification] (https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification) | ||
| Opening Hours and the time frame during which time dependent properties are applicable are indicated following the [OSM Opening Hours specification](https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification) |
There was a problem hiding this comment.
This is right.
copilot (or someone else): Apply this fix to the other sections and add a newline between the section header and the first paragraph.
|
|
||
| ### Opening hours/validity Periods | ||
| Opening Hours and the time frame during which time dependent properties are applicable are indicated following the [OSM Opening Hours specification] (https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification) | ||
| Opening Hours and the time frame during which time dependent properties are applicable are indicated following the [OSM Opening Hours specification](https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification) |
There was a problem hiding this comment.
This is right.
copilot (or someone else): Apply this fix to the other sections and add a newline between the section header and the first paragraph.
Signed-off-by: Victor Schappert <victor.schappert@protonmail.com>
e13679c
|
Applied the suggestion: Roel Bollens (@RoelBollens-TomTom) and Seth Fitzsimmons (@sethfitz) can you re-up your approval? |
|
Hi amir-rezaei — thanks for this contribution! There's just one thing blocking the merge: the DCO check is failing. What's wrongDCO requires every commit from an external contributor to carry a Signed-off-by: line. Your commit is missing it: How to fix itI think the simplest way to fix it is:
At that point the DCO checks should pass and it should be merge ready. Again thanks! |
Seth Fitzsimmons (sethfitz)
left a comment
There was a problem hiding this comment.
Approved, but there are other indented lines that remain which deserve the same treatment (as well as making it lint-clean). I'll send a follow-up.
Description
This PR fixes broken Markdown link formatting and a minor typo in .
Details
add hoc->ad hocunder the Extensions section.Fixes #615