[CHORE](annex) Place py.typed marker in the annex package, not the namespace root - #619
Open
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Open
[CHORE](annex) Place py.typed marker in the annex package, not the namespace root#619Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Conversation
overture-schema-annex shipped its PEP 561 marker at src/overture/schema/py.typed -- the shared overture.schema namespace level -- instead of src/overture/schema/annex/py.typed, where its code lives. A py.typed marker applies to the package directory it sits in; at the namespace level it claims the shared namespace is typed rather than marking overture.schema.annex. Hatchling's packages = ["src/overture"] vacuum includes the whole tree, so the misplacement is masked today. It surfaces under any module-root-scoped build backend (e.g. uv_build), which would drop the marker silently. Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
❌ Linked Issue Check FailedThis PR does not reference enough linked issues (found 0, required 1). Please link an issue from this repository, using After adding a linked issue, you may need to manually re-run this check from the Checks tab to update the status. |
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Collaborator
|
PR #629 should make this one moot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overture-schema-annex shipped its PEP 561 marker at
src/overture/schema/py.typed— the sharedoverture.schemanamespace level — instead ofsrc/overture/schema/annex/py.typed, where its code lives. Apy.typedmarker applies to the package directory it sits in; at the namespace level it claims the shared namespace is typed rather than markingoverture.schema.annex.Hatchling's
packages = ["src/overture"]vacuum includes the whole tree, so the misplacement is masked today. It surfaces under any module-root-scoped build backend (uv_build), which would drop the marker silently — which is why this lands ahead of the uv_build migration.Bottom of a three-PR stack migrating the workspace to uv_build / PEP 420 packaging.
Closes #621