Failing readthedocs

[arnfinn]

Failed with this commit: 809e4a9

Reason:
Line 83 in doc/conf.py throws an error since prere is NoneType.

Error:

  File "conf.py", line 83, in <module>
    tweak = '+'.join([prere, sha])
TypeError: sequence item 0: expected str instance, NoneType found

Dirty fix:

-tweak = '+'.join([prere, sha])
+try:
+    tweak = '+'.join([prere, sha])
+except:
+    tweak = sha

[robertodr]

Yep. I am on it. I will also have to add "check that docs build" to the release management documentation.

…

On Fri, Apr 27, 2018, 17:15 Arnfinn Hykkerud Steindal < ***@***.***> wrote: Failed with this commit: 809e4a9 <809e4a9> Reason: Line 83 in doc/conf.py throws an error since prere is *NoneType*. Error: File "conf.py", line 83, in <module> tweak = '+'.join([prere, sha]) TypeError: sequence item 0: expected str instance, NoneType found Dirty fix: -tweak = '+'.join([prere, sha]) +try: + tweak = '+'.join([prere, sha]) +except: + tweak = sha — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#163>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADiXES-R0oyyNFfFnaTd7X7gztfqIjKbks5ts4p5gaJpZM4TrBl1> .

[arnfinn]

Do we run sphinx-build . _build with Travis to see if a PR/commit break readthedocs? If not, maybe we could add it. Maybe also run htmlproofer afterwards.

[arnfinn]

Fixed here: e882df9