GLM-4.5 model accuracy alignment - #5
Open
zhanghonggeng wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds bit-exact numerical alignment patches between Megatron-LM and PaddleFleet for the GLM-4.5 MoE model, gated by
USE_ACCURACY_COMPATIBLE=1environment variable. When disabled, all original code paths remain unchanged.Changes Overview
Router scoring (
moe_utils.py,router.py)local_tokens_per_expertaccumulation for expert bias updates during alignment mode.Permute/Unpermute (
moe_utils.py)_PermuteAlignedAutogradFn: deterministic gather-reshape-sum backward (fp32) matching PaddleFleet's_PermuteAlignedPyLayer.embeddinglookup + reshape-sum instead of non-deterministicscatter_add_.SwiGLU activation (
fused_bias_swiglu.py)BiasSwiGLUFunction,SwiGLUFunction, andWeightedSwiGLUFunctionto match PaddleFleet's unfused computation order.Cross-entropy loss (
language_module.py)F.cross_entropyin fp32 (non-TP-split) when alignment mode is active, matching PaddleFleet's per-token loss calculation.Embedding (
layers.py)weight[masked_input]indexing (deterministic backward) instead ofF.embedding.Expert forward (
experts.py)Grad finalization (
finalize_model_grads.py)num_tokensscaling when loss is already normalized in the autograd graph (PaddleFleet's fixed-loss path).Optimizer (
distrib_optimizer.py)torch.optim.AdamWinDistributedOptimizerfor alignment with PaddleFleet's optimizer choice.MoE layer (
moe_layer.py)Code quality
import os.Testing
USE_ACCURACY_COMPATIBLE=1; default behavior is unchanged.