Skip to content

Remove context menu on touch devices#1145

Draft
1nf0rmagician wants to merge 1 commit intodevfrom
fix/scrolling-trees
Draft

Remove context menu on touch devices#1145
1nf0rmagician wants to merge 1 commit intodevfrom
fix/scrolling-trees

Conversation

@1nf0rmagician
Copy link
Member

@1nf0rmagician 1nf0rmagician commented Mar 7, 2026

Summary

A long touch interaction triggers scrolling and contextmenu events. As the context menu event in the resource and products tree prevents defaults (to show a custom context menu), also the scrolling default behaviour is removed. To allow scrolling on touch displays we remove the context menu functionality on touch devices. All options from the context menu have been available on the toolbar before and still are.

Linked Issues

Checklist for Submitter

  • I have tested these changes locally
  • I have updated documentation as needed
  • I have added or updated tests as appropriate
  • I have used clear and descriptive commit messages

Review

Typical tasks

  • Merge request is well described
  • Critical sections are documented in code
  • Tests are extended
  • Documentation is created / updated
  • Running in test environment
  • Ports to other maintained versions are created

Clean code

  • All unused references are removed
  • Clean code rules are respected with passion (naming, ...)
  • Avoid copy and pasted code snippets

ToDo:

  • Test on actual touch device. Scrolling on touch emulation in chrome had worked before as well.
  • Apply same changes to resources

A long touch interaction triggers scrolling and contextmenu events. As the context menu event in the resource and products tree prevents defaults (to show a custom context menu), also the scrolling default behaviour is removed.
To allow scrolling on touch displays we remove the context menu functionality on touch devices. All options from the context menu have been available on the toolbar before and still are.
@1nf0rmagician 1nf0rmagician marked this pull request as draft March 7, 2026 21:07
@1nf0rmagician 1nf0rmagician requested a review from dbeuchler March 7, 2026 21:07
@1nf0rmagician 1nf0rmagician self-assigned this Mar 7, 2026
@1nf0rmagician 1nf0rmagician added the bug Something isn't working label Mar 7, 2026
@1nf0rmagician 1nf0rmagician added this to the Framework 10.x milestone Mar 7, 2026
Copy link
Member

@dbeuchler dbeuchler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When they are already in the toolbar - why providing it in context-menu too? Nevertheless, a good change, thank you very much, now the trees can be operated on a touch device again.

I can test it on a touch device later and give you feedback.

@1nf0rmagician
Copy link
Member Author

When they are already in the toolbar - why providing it in context-menu too?

When you have a mouse you can use the context menu to call the actions on not selected products. Keeping the details of the current product in focus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants