Added support for publishing notifications async#956
Draft
Added support for publishing notifications async#956
Conversation
dbeuchler
force-pushed
the
feature/async-notification-publish
branch
from
a37ee18 to
1a40316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotificationAdapter supports async publishing now.
PublishAsyncwill returntrueif the notification was published and processed, andfalseif it was not processed before acknowledgement. It adds the ability to await the processing of the notification to get information (like texts) from the processed notification.The implementation is a POC. For the 10.0.0 release, we could just add the methods to the INotificationAdapter interface as preparation and add feature implementation in 10.x. @1nf0rmagician does this make sense for you?