Reusable remark workflow: bump Node from 20 to 24#41
Merged
jrfnl merged 1 commit intoJun 18, 2026
Conversation
12 tasks
Member
|
Thanks @rodrigoprimo ! One question: why Node 22 ? What I mean by that is: why not bump to Node 24 while we're at it ? Is there anything which would currently block that ? |
`dead-or-alive@1.0.5` (2026-06-03), pulled in transitively via `remark-lint-no-dead-urls`, bumped `undici` to `^8`. `undici@8` calls `markAsUncloneable`, a Node API only available from Node 22.10.0, so on Node 20 it fails with `TypeError: webidl.util.markAsUncloneable is not a function`, which has broken the `QA Markdown` job across the org since 2026-06-05.
d6a2ffc to
3935999
Compare
Contributor
Author
|
Good question! I think what happened is that I saw I can confirm that everything works with Node 24. I force pushed the original commit and updated the description and title. This PR now suggests updating to Node 24. |
jrfnl
approved these changes
Jun 18, 2026
jrfnl
left a comment
Member
There was a problem hiding this comment.
Thanks for the update @rodrigoprimo ! All good from me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
QA Markdownjob has been failing across the org with the following error:dead-or-alive@1.0.5, pulled in transitively viaremark-lint-no-dead-urls, bumpedundicito^8.undici@8callsmarkAsUncloneable, a Node API only available from Node 22.10.0, while the workflow uses Node 20.This PR bumps
node-versionto"24", which fixes the failure and also moves CI off Node 20 (end of life).Fixes the failing
QA Markdowncheck on open PRs across the org. Examples: PHPCSStandards/PHPCSExtra#439 and PHPCSStandards/PHP_CodeSniffer#1438.How this was tested
I tested this change using
acton my machine with the following temporary workflow file:On
mainthe job crashes with themarkAsUncloneableerror. On this branch it loads.remarkrcand lints successfully.