Combining the setAutoFilter and setAutoSize

[cwolcott]

This is:

- [X] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

I initially reported this in #2274, but then prematurely closed it when I thought it was fixed.

I would have hoped that using the setAutoSize function would have appropriately determined the correct size for a column when the function setAutoFilter had already be applied.

        Font::setTrueTypeFontPath("/usr/share/fonts/msttcore/");
        Font::setAutoSizeMethod(Font::AUTOSIZE_METHOD_EXACT);
        ...
        // Apply filtering capability to the worksheet
        $worksheet->setAutoFilter($worksheet->calculateWorksheetDimension());

        // Apply auto size to all columns
        foreach (range('A',$workSheetMaxColumns) as $col) { $worksheet->getColumnDimension($col)->setAutoSize(true); }
        ...

What is the current behavior?

It does not seem to take into account the filter icon shown in the column. See attached images

When I double click on the column seperator in excel it widens the column widths to my satisfaction.

Which versions of PhpSpreadsheet and PHP are affected?

version 1.18.0+

I thought this was fixed, but I guess I fixed it myself and then lost the fix when upgrading from 1.18.0 to 1.20.0. I am trying to figure out what I did to fix it.

Before in 1.18.0 with may fix:

After in 1.20.0 after losing my fix:

You can see that the columns are not taking in account the filter icon.

[cwolcott]

Does anyone have any thoughts on this. I know the current workaround is not correct, but it helps be get past the issue for the time being.

Shared/Font.php (line 249), the multiple was 1.07. I changed it to 3.5 for fun.

        if (!$approximate) {
            $columnWidthAdjust = ceil(self::getTextWidthPixelsExact('n', $font, 0) * 3.5);

[cwolcott]

@MarkBaker Thank you very much that makes it a lot better. I would suggest increasing the adjustment from 3 to 5.
Line 256 str_repeat('n', 1 * ($filterAdjustment ? 5 : 1)),
Line 273 str_repeat('n', 1 * ($filterAdjustment ? 5 : 1)),

With a value of 3 the filer dropdown icon is still very tight.

Looks better with a value of 5

[MarkBaker]

Hmm, 3 should be adequate for plain text; I may do a little tweak to test for bold or italic and use 5 in those cases