Closed
Conversation
PowerKiKi
requested changes
Aug 12, 2019
Member
PowerKiKi
left a comment
PowerKiKi
left a comment
There was a problem hiding this comment.
Could you please add unit tests that demonstrate the bug and that prove that your patch is working ?
Jane-SuSu
force-pushed
the
fixGetCalculatedValueIndirect
branch
4 times, most recently
from
ef5a241 to
b8c5274
Compare
Jane-SuSu
force-pushed
the
fixGetCalculatedValueIndirect
branch
from
b8c5274 to
5fa9fd8
Compare
Author
|
Hi, I've added unit test to demonstrate the bug. Please review it, thanks. |
PowerKiKi
approved these changes
Aug 17, 2019
Member
|
Thanks ! it's been merged |
PowerKiKi
added a commit
that referenced
this pull request
Aug 17, 2019
1.9.0 ### Added - When <br> appears in a table cell, set the cell to wrap [#1071](#1071) and [#1070](#1070) - Add MAXIFS, MINIFS, COUNTIFS and Remove MINIF, MAXIF [#1056](#1056) - HLookup needs an ordered list even if range_lookup is set to false [#1055](#1055) and [#1076](#1076) - Improve performance of IF function calls via ranch pruning to avoid resolution of every branches [#844](#844) - MATCH function supports `*?~` Excel functionality, when match_type=0 [#1116](#1116) - Allow HTML Reader to accept HTML as a string [#1136](#1136) ### Fixed - Fix to AVERAGEIF() function when called with a third argument - Eliminate duplicate fill none style entries [#1066](#1066) - Fix number format masks containing literal (non-decimal point) dots [#1079](#1079) - Fix number format masks containing named colours that were being misinterpreted as date formats; and add support for masks that fully replace the value with a full text string [#1009](#1009) - Stricter-typed comparison testing in COUNTIF() and COUNTIFS() evaluation [#1046](#1046) - COUPNUM should not return zero when settlement is in the last period [#1020](#1020) and [#1021](#1021) - Fix handling of named ranges referencing sheets with spaces or "!" in their title - Cover `getSheetByName()` with tests for name with quote and spaces [#739](#739) - Best effort to support invalid colspan values in HTML reader - [#878](#878) - Fixes incorrect rows deletion [#868](#868) - MATCH function fix (value search by type, stop search when match_type=-1 and unordered element encountered) [#1116](#1116) - Fix `getCalculatedValue()` error with more than two INDIRECT [#1115](#1115) - Writer\Html did not hide columns [#985](#985)
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
1.9.0 ### Added - When <br> appears in a table cell, set the cell to wrap [PHPOffice#1071](PHPOffice#1071) and [PHPOffice#1070](PHPOffice#1070) - Add MAXIFS, MINIFS, COUNTIFS and Remove MINIF, MAXIF [PHPOffice#1056](PHPOffice#1056) - HLookup needs an ordered list even if range_lookup is set to false [PHPOffice#1055](PHPOffice#1055) and [PHPOffice#1076](PHPOffice#1076) - Improve performance of IF function calls via ranch pruning to avoid resolution of every branches [PHPOffice#844](PHPOffice#844) - MATCH function supports `*?~` Excel functionality, when match_type=0 [PHPOffice#1116](PHPOffice#1116) - Allow HTML Reader to accept HTML as a string [PHPOffice#1136](PHPOffice#1136) ### Fixed - Fix to AVERAGEIF() function when called with a third argument - Eliminate duplicate fill none style entries [PHPOffice#1066](PHPOffice#1066) - Fix number format masks containing literal (non-decimal point) dots [PHPOffice#1079](PHPOffice#1079) - Fix number format masks containing named colours that were being misinterpreted as date formats; and add support for masks that fully replace the value with a full text string [PHPOffice#1009](PHPOffice#1009) - Stricter-typed comparison testing in COUNTIF() and COUNTIFS() evaluation [PHPOffice#1046](PHPOffice#1046) - COUPNUM should not return zero when settlement is in the last period [PHPOffice#1020](PHPOffice#1020) and [PHPOffice#1021](PHPOffice#1021) - Fix handling of named ranges referencing sheets with spaces or "!" in their title - Cover `getSheetByName()` with tests for name with quote and spaces [PHPOffice#739](PHPOffice#739) - Best effort to support invalid colspan values in HTML reader - [PHPOffice#878](PHPOffice#878) - Fixes incorrect rows deletion [PHPOffice#868](PHPOffice#868) - MATCH function fix (value search by type, stop search when match_type=-1 and unordered element encountered) [PHPOffice#1116](PHPOffice#1116) - Fix `getCalculatedValue()` error with more than two INDIRECT [PHPOffice#1115](PHPOffice#1115) - Writer\Html did not hide columns [PHPOffice#985](PHPOffice#985)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Because when the formula got two or more INDIRECT in one line, the file will NOT be generated. It is a very dangerous for output a file. So we need to fix it.