Fix for Xls writer wrong cells and sheet selection.#1256
Merged
PowerKiKi merged 1 commit intoPHPOffice:masterfrom Mar 2, 2020
Merged
Fix for Xls writer wrong cells and sheet selection.#1256PowerKiKi merged 1 commit intoPHPOffice:masterfrom
PowerKiKi merged 1 commit intoPHPOffice:masterfrom
Conversation
jimmy4o4
force-pushed
the
master
branch
3 times, most recently
from
64bf016 to
e0f5824
Compare
PowerKiKi
requested changes
Nov 30, 2019
Member
PowerKiKi
left a comment
PowerKiKi
left a comment
There was a problem hiding this comment.
This is a nice improvement, but we would need to cover it with testing. You can have a look at \PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional and sibling classes to see how to test writing and reading files.
PowerKiKi
added
missing test
writer/xls
Contributor
Author
|
Fix for Xls BIFF window2 structure was needed too. I've added some tests too. All of this covers only problems with Xls. Ods and Xlsx are still affected, I'm not sure, if there is any possible solution for these file types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
See #1250 .