Skip to content

Chart Samples Fix #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cwolcott wants to merge 3 commits into from
Closed

Chart Samples Fix #1448

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b09bf2
Chart Samples Fix
cwolcott Apr 18, 2020
49a0304
Chart Samples Fix
cwolcott Apr 18, 2020
d80335f
Chart Sample Fix
cwolcott Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Chart Samples Fix 
Added additional constants EMPTY_AS_ZERO and EMPTY_AS_SPAN
  • Loading branch information
@cwolcott
cwolcott committed Apr 18, 2020
commit 49a0304fe8210082054ef380008d67338414f4e7
2 changes: 1 addition & 1 deletion src/PhpSpreadsheet/Chart/Chart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class Chart
* @param null|GridLines $majorGridlines
* @param null|GridLines $minorGridlines
*/
public function __construct($name, Title $title = null, Legend $legend = null, PlotArea $plotArea = null, $plotVisibleOnly = true, $displayBlanksAs = 'gap', Title $xAxisLabel = null, Title $yAxisLabel = null, Axis $xAxis = null, Axis $yAxis = null, GridLines $majorGridlines = null, GridLines $minorGridlines = null)
public function __construct($name, Title $title = null, Legend $legend = null, PlotArea $plotArea = null, $plotVisibleOnly = true, $displayBlanksAs = DataSeries::EMPTY_AS_GAP, Title $xAxisLabel = null, Title $yAxisLabel = null, Axis $xAxis = null, Axis $yAxis = null, GridLines $majorGridlines = null, GridLines $minorGridlines = null)
{
$this->name = $name;
$this->title = $title;
Expand Down
2 changes: 2 additions & 0 deletions src/PhpSpreadsheet/Chart/DataSeries.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ class DataSeries
const STYLE_FILLED = 'filled';

const EMPTY_AS_GAP = 'gap';
const EMPTY_AS_ZERO = 'zero';
const EMPTY_AS_SPAN = 'span';

/**
* Series Plot Type.
Expand Down