Skip to content

Fix/sheets xlsx chart#1761

Merged
MarkBaker merged 3 commits intoPHPOffice:masterfrom
hazybluedot:fix/sheetsXlsxChart
Jan 31, 2021
Merged

Fix/sheets xlsx chart#1761
MarkBaker merged 3 commits intoPHPOffice:masterfrom
hazybluedot:fix/sheetsXlsxChart

Conversation

@hazybluedot
Copy link
Contributor

@hazybluedot hazybluedot commented Dec 20, 2020

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

When exporting Google Sheets as Xlsx, charts are positioned using oneCellAnchor which previously had not been implemented. In additional exported Xlsx files do not contain the *Cache element. Since *Chache elements had been assumed to be children of numRef and strRef elements, "Node has been deleted" errors were thrown when attempting to read an Xlsx exported from Google Sheets.

Google Sheets XLSX charts use oneCellAnchor positioning and the data series
do not have the *Cache elements with cached values.
Google Sheets XLSX charts use oneCellAnchor positioning and the data series
do not have the *Cache elements with cached values. Because the reader had been
assuming *Cache elements existed as children of strRef and numRef, errors about
the node being deleted were thrown when reading Xlsx exported from Google Sheets.
@MarkBaker
Copy link
Member

Thank you for providing this resolution to one-cell-anchor charts, and the issue with cache elements

@MarkBaker MarkBaker merged commit 44248cd into PHPOffice:master Jan 31, 2021
BlackyTay pushed a commit to BlackyTay/PhpSpreadsheet that referenced this pull request Aug 8, 2025
* Add support for Google Sheets Exported XLSX Charts

Google Sheets XLSX charts use oneCellAnchor positioning and the data series
do not have the *Cache elements with cached values.

* update CHANGELOG

* Add support for Google Sheets Exported XLSX Charts

Google Sheets XLSX charts use oneCellAnchor positioning and the data series
do not have the *Cache elements with cached values. Because the reader had been
assuming *Cache elements existed as children of strRef and numRef, errors about
the node being deleted were thrown when reading Xlsx exported from Google Sheets.

Co-authored-by: Darren Maczka <dkm@utk.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants