Skip to content

R1C1 conversion should handle absolute A1 references #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkBaker merged 4 commits into from
May 7, 2021
Merged

R1C1 conversion should handle absolute A1 references #2060

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aeb21f7
R1C1 conversion should handle absolute A1 references
ndench May 4, 2021
c7f65bb
Update CHANGELOG.md with R1C1 conversion change
ndench May 4, 2021
c2fa059
Remove complexity from AddressHelper::convertToR1C1
ndench May 5, 2021
1adc188
Use named regex groups and constants for regex strings
ndench May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md with R1C1 conversion change
  • Loading branch information
@ndench
ndench committed May 4, 2021
commit c7f65bb8a4c86ebaead8f04e94a5c7824ad2d2c3
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
- Nothing.

### Fixed
- Correctly handle absolute A1 references when converting to R1C1 format [PR #2060](https://github.com/PHPOffice/PhpSpreadsheet/pull/2060)
- Correct default fill style for conditional without a pattern defined [Issue #2035](https://github.com/PHPOffice/PhpSpreadsheet/issues/2035) [PR #2050](https://github.com/PHPOffice/PhpSpreadsheet/pull/2050)
- Fixed issue where array key check for existince before accessing arrays in Xlsx.php. [PR #1970](https://github.com/PHPOffice/PhpSpreadsheet/pull/1970)
- Fixed issue with quoted strings in number format mask rendered with toFormattedString() [Issue 1972#](https://github.com/PHPOffice/PhpSpreadsheet/issues/1972) [PR #1978](https://github.com/PHPOffice/PhpSpreadsheet/pull/1978)
Expand Down