Updates to documentation concerning Value Binders#2138
Merged
Conversation
added 2 commits
June 2, 2021 18:44
Fix a couple of checks on characters at positions within a string before checking the length of the string when the offset may not exist
Collaborator
|
Now that you are adding StringValueBinder to the docs, could you make it clear that String Value Binder also converts null and boolean to strings, and that a custom binder might be needed if that isn't the desired behavior? I got into a lengthy discussion with someone about that. I'll find that issue number later. |
Collaborator
|
Discussion to which I referred was in issue #1977. |
added 10 commits
June 3, 2021 14:10
…rings in the StringValueBinder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a couple of checks on characters at positions within a string before checking the length of the string when the offset may not exist
This is:
Checklist:
Why this change is needed?
Update the documentation on Value Binders to include the case where numeric strings won't be converted to numbers, and reference the StringValueBinder