Skip to content

Updates to documentation concerning Value Binders#2138

Merged
MarkBaker merged 12 commits intomasterfrom
Value-Binder-Documentation-Updates
Jun 3, 2021
Merged

Updates to documentation concerning Value Binders#2138
MarkBaker merged 12 commits intomasterfrom
Value-Binder-Documentation-Updates

Conversation

@MarkBaker
Copy link
Member

Fix a couple of checks on characters at positions within a string before checking the length of the string when the offset may not exist

This is:

- [ ] a bugfix
- [ ] a new feature
- [X] documentation

Checklist:

Why this change is needed?

Update the documentation on Value Binders to include the case where numeric strings won't be converted to numbers, and reference the StringValueBinder

MarkBaker added 2 commits June 2, 2021 18:44
Fix a couple of checks on characters at positions within a string before checking the length of the string when the offset may not exist
@oleibman
Copy link
Collaborator

oleibman commented Jun 2, 2021

Now that you are adding StringValueBinder to the docs, could you make it clear that String Value Binder also converts null and boolean to strings, and that a custom binder might be needed if that isn't the desired behavior? I got into a lengthy discussion with someone about that. I'll find that issue number later.

@oleibman
Copy link
Collaborator

oleibman commented Jun 3, 2021

Discussion to which I referred was in issue #1977.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants