fix #1114 issue#2308
Merged
oleibman merged 7 commits intoPHPOffice:masterfrom Oct 3, 2021
tezrik:master
Merged
Conversation
Collaborator
|
Can you add a unit test which (a) fails without your change and (b) succeeds with your change? |
Contributor
Author
|
I add test |
Collaborator
|
Thanks. I plan to merge this in a few days. In the meantime, can you please expand on this comment "this has to do with that index 4 is omitted in all BIFF versions for some strange reason ... check the OpenOffice documentation of the FONT record"? If there is something in the official documentation, I would just like to include it with this PR. You can just include it as a comment in the PR; not necessary to add it to the source code. |
Contributor
Author
|
I remove comment about "index in all biff version". In documentation OpenOffice not explanations on issue #1114. |
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
* fix PHPOffice#1114 issues * fixed code style * update for all version * add test for bag 1114 * remove comment Co-authored-by: georgio <georgiokot@gmail.cim>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Fixed #1114 issue