[TASK] Lowercase calibri fontnames#2325
Merged
oleibman merged 1 commit intoPHPOffice:masterfrom Oct 16, 2021
ayacoo:task/2273-calibri-font-names
Merged
[TASK] Lowercase calibri fontnames#2325oleibman merged 1 commit intoPHPOffice:masterfrom ayacoo:task/2273-calibri-font-names
oleibman merged 1 commit intoPHPOffice:masterfrom
ayacoo:task/2273-calibri-font-names
Conversation
Collaborator
|
I usually like to see a unit test demonstrating that the change works. However, such a test here would require that the testing system contain fonts which are often not present on the system, and I see no reason to make the presence of these fonts a requirement for using the package. Indeed, there are no current unit tests for this functionality, probably for this reason. Perhaps it is possible to come up with reasonable tests, but this change need not be delayed awaiting those. It seems very simple, and looks correct. |
Contributor
Author
|
One option might be to test the constants still fixed. These are not the most interesting tests, but so you could track such changes a little. |
Collaborator
|
Thank you for your contribution. |
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #2273