Use getFromName instead of getFromIndex and locateName#268
Closed
anton-harvey wants to merge 1 commit intoPHPOffice:developfrom
Closed
Use getFromName instead of getFromIndex and locateName#268anton-harvey wants to merge 1 commit intoPHPOffice:developfrom
anton-harvey wants to merge 1 commit intoPHPOffice:developfrom
Conversation
Member
|
Thanks ! I reworded the commit message to explain why, rather that what, and added a line to the changelog. |
Dfred
pushed a commit
to Dfred/PhpSpreadsheet
that referenced
this pull request
Nov 20, 2018
Previously the function did not check whether the return value of `ZipArchive::locateName` was `false`. And when it was, it was passed straight into `ZipArchive::getFromIndex`, which casts it to an integer, resulting in it incorrectly retrieving the entry at index `0`. Fixes PHPOffice#262 Closes PHPOffice#268
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
Previously the function did not check whether the return value of `ZipArchive::locateName` was `false`. And when it was, it was passed straight into `ZipArchive::getFromIndex`, which casts it to an integer, resulting in it incorrectly retrieving the entry at index `0`. Fixes PHPOffice#262 Closes PHPOffice#268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
What does it change?
Fixes #262. Let me know if you need me to check more of the above boxes.