Skip to content

Fix invalid styles in empty columns of added external sheet.#2739

Merged
MarkBaker merged 9 commits intoPHPOffice:masterfrom
mjan4175:fix-external-sheet-column-styles
Apr 13, 2022
Merged

Fix invalid styles in empty columns of added external sheet.#2739
MarkBaker merged 9 commits intoPHPOffice:masterfrom
mjan4175:fix-external-sheet-column-styles

Conversation

@mjan4175
Copy link
Contributor

@mjan4175 mjan4175 commented Apr 11, 2022

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Copy link
Member

@MarkBaker MarkBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a similar issue with row dimensions? If so, then it might be appropriate to resolve that problem as part of the same PR

@mjan4175
Copy link
Contributor Author

You're right, there was a similar issue with row dimensions.
I added another fix to this PR.

@MarkBaker
Copy link
Member

Thank you for this very useful contribution

@MarkBaker MarkBaker merged commit 4856376 into PHPOffice:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants