Skip to content

Handling Structured References in the Calculation Engine#3261

Merged
MarkBaker merged 6 commits intomasterfrom
CalcEngine_Structured-References
Dec 29, 2022
Merged

Handling Structured References in the Calculation Engine#3261
MarkBaker merged 6 commits intomasterfrom
CalcEngine_Structured-References

Conversation

@MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Dec 23, 2022

This is:

- [ ] a bugfix
- [X] a new feature
- [ ] refactoring
- [ ] additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change
  • Documentation is updated as necessary

Why this change is needed?

Allow Calculation Engine to process Structured References in formulae, converting them to a cell range

@MarkBaker MarkBaker marked this pull request as draft December 23, 2022 22:44
@MarkBaker MarkBaker force-pushed the CalcEngine_Structured-References branch 2 times, most recently from 5eef3bb to 5fff0ad Compare December 26, 2022 18:58
@MarkBaker MarkBaker changed the title Initial work on handling Structured References in the Calculation Engine Handling Structured References in the Calculation Engine Dec 26, 2022
@MarkBaker MarkBaker marked this pull request as ready for review December 26, 2022 23:16
@MarkBaker MarkBaker force-pushed the CalcEngine_Structured-References branch from 5fff0ad to bafeacb Compare December 26, 2022 23:18
@MarkBaker MarkBaker force-pushed the CalcEngine_Structured-References branch from 2903ad9 to adbc981 Compare December 27, 2022 20:50
@MarkBaker
Make Structured Reference parsing case-insensitive, by switching from…
3ac5155 
… strpos to preg_match, allowing re-use of the pattern in preg_replace for convenience
@MarkBaker MarkBaker force-pushed the CalcEngine_Structured-References branch from adff7a3 to 3ac5155 Compare December 29, 2022 15:25
@MarkBaker MarkBaker merged commit cff73fb into master Dec 29, 2022
@MarkBaker MarkBaker deleted the CalcEngine_Structured-References branch December 29, 2022 17:06
@tristanbailey tristanbailey mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MarkBaker