Skip to content

Allow a range of different potential currency codes in the currency matcher regexp#3373

Merged
MarkBaker merged 2 commits intomasterfrom
CalcEngine_Formatted-Currency-Expand-Currency-Range
Feb 17, 2023
Merged

Allow a range of different potential currency codes in the currency matcher regexp#3373
MarkBaker merged 2 commits intomasterfrom
CalcEngine_Formatted-Currency-Expand-Currency-Range

Conversation

@MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Allow a range of different potential currency codes (including the locale currency code) in the currency matcher regexp
(dollar, euro, pound sterling and yen)

…cale code) in the currency matcher regexp

(dollar, euro, pound sterling and yen)
@MarkBaker MarkBaker marked this pull request as ready for review February 17, 2023 05:37
@MarkBaker MarkBaker merged commit d029042 into master Feb 17, 2023
@MarkBaker MarkBaker deleted the CalcEngine_Formatted-Currency-Expand-Currency-Range branch February 17, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant