Skip to content

TEXT Function Ignores Time in DateTimeStamp#3411

Merged
oleibman merged 2 commits intoPHPOffice:masterfrom
oleibman:issue3409
Mar 2, 2023
Merged

TEXT Function Ignores Time in DateTimeStamp#3411
oleibman merged 2 commits intoPHPOffice:masterfrom
oleibman:issue3409

Conversation

@oleibman
Copy link
Collaborator

Fix #3409. Calculate both the date and time portions when a date/time format is supplied for the TEXT function.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Fix PHPOffice#3409. Calculate both the date and time portions when a date/time format is supplied for the TEXT function.
@lucasnetau
Copy link
Contributor

Thanks @oleibman , tested correctly against my spreadsheet.

@oleibman
Copy link
Collaborator Author

@lucasnetau Thank you for confirming. I will merge this change some time this week.

@oleibman oleibman merged commit 66221bf into PHPOffice:master Mar 2, 2023
@oleibman oleibman deleted the issue3409 branch March 24, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

TEXT format with only time string returns 0 instead of the time

2 participants