Skip to content

Modify Date/Time check in the NumberFormatter for decimal/fractional times#3413

Merged
MarkBaker merged 1 commit intomasterfrom
Issue-3412_Date-Format-with_decimals-interpreted-as-Number-Format
Feb 28, 2023
Merged

Modify Date/Time check in the NumberFormatter for decimal/fractional times#3413
MarkBaker merged 1 commit intomasterfrom
Issue-3412_Date-Format-with_decimals-interpreted-as-Number-Format

Conversation

@MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Issue #3412

Modify Date/Time check in the NumberFormatter so that masks with a decimal/fractional time aren't misinterpreted as number masks, while still ensuring that durations are interpreted as date/time masks, and locale currency masks are still treated as numbers

A date/time with a decimal time shouldn't have a digit placeholder before the decimal point, only after

…cimal/fractional time aren't misinterpreted as number masks, while still ensuring that durations are interpreted as date/time masks, and locale currency masks are still treated as numbers

A date/time with a decimal time shouldn't have a digit placeholder __before__ the decimal point, only after
@MarkBaker MarkBaker merged commit 717a44a into master Feb 28, 2023
@MarkBaker MarkBaker deleted the Issue-3412_Date-Format-with_decimals-interpreted-as-Number-Format branch February 28, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant