Skip to content

Option to Whitelist External Images#4793

Merged
oleibman merged 5 commits intoPHPOffice:masterfrom
oleibman:listpix
Feb 11, 2026
Merged

Option to Whitelist External Images#4793
oleibman merged 5 commits intoPHPOffice:masterfrom
oleibman:listpix

Conversation

@oleibman
Copy link
Collaborator

Loading external images from a spreadsheet can subject the caller to security exploits. For those who think they need something between not loading any external images (the default and our strong recommendation) or loading them all unconditionally (the current alternative), a callback can now be provided to indicate whether a specific image is okay to load. We continue to urge caution in using this option.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Loading external images from a spreadsheet can subject the caller to security exploits. For those who think they need something between not loading any external images (the default and our strong recommendation) or loading them all unconditionally (the current alternative), a callback can now be provided to indicate whether a specific image is okay to load. We continue to urge caution in using this option.
@oleibman oleibman enabled auto-merge February 11, 2026 03:32
@oleibman oleibman added this pull request to the merge queue Feb 11, 2026
Merged via the queue into PHPOffice:master with commit f79394b Feb 11, 2026
14 checks passed
@oleibman oleibman deleted the listpix branch February 11, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant