Skip to content

Function EXACT support#595

Merged
PowerKiKi merged 5 commits intoPHPOffice:developfrom
rolandsusans:add-exact-function
Jul 15, 2018
Merged

Function EXACT support#595
PowerKiKi merged 5 commits intoPHPOffice:developfrom
rolandsusans:add-exact-function

Conversation

@rolandsusans
Copy link
Contributor

This is: Function EXACT support

- [x] a new feature

Checklist:

Why this change is needed?

Implements excel EXACT function support ( instead of using dummy wrapper use actual implementation)

Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should only move documentation to proper documentation files

README.md Outdated

PhpSpreadsheet is licensed under [LGPL (GNU LESSER GENERAL PUBLIC LICENSE)](https://github.com/PHPOffice/PhpSpreadsheet/blob/master/LICENSE)

### TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be kept as short as possible. Instead we have a page in documentation that cover supported functions. That should be where we keep a complete list of supported/non-supported functions

@PowerKiKi
Copy link
Member

Oh, you should also use composer fix to fix code style

@rolandsusans
Copy link
Contributor Author

@PowerKiKi is there chance to get this PR in master?

@PowerKiKi PowerKiKi merged commit eb31899 into PHPOffice:develop Jul 15, 2018
@rolandsusans rolandsusans deleted the add-exact-function branch August 7, 2018 06:44
Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this pull request Nov 20, 2018
BlackyTay pushed a commit to BlackyTay/PhpSpreadsheet that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants