Skip to content

skip non numeric value in SUMIF#618

Merged
PowerKiKi merged 5 commits intoPHPOffice:developfrom
Scorty:develop
Oct 7, 2018
Merged

skip non numeric value in SUMIF#618
PowerKiKi merged 5 commits intoPHPOffice:developfrom
Scorty:develop

Conversation

@Scorty
Copy link
Contributor

@Scorty Scorty commented Jul 31, 2018

This is:

- [x ] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

MS Excel skip non numeric values also. PhpSpreadsheet fail on string value with: Warning: A non-numeric value encountered

PHP 7.1.18

Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This miss unit test to be merged. Could you please add some cases, most likely in tests/data/Calculation/MathTrig/SUMIF.php ?

Also update the CHANGELOG.md

@Scorty
Copy link
Contributor Author

Scorty commented Oct 4, 2018

Sorry but CI failed on file tests that I did not change :-(

@PowerKiKi PowerKiKi merged commit ae9dd13 into PHPOffice:develop Oct 7, 2018
@PowerKiKi
Copy link
Member

Thanks !

@DuckDensity DuckDensity mentioned this pull request Oct 25, 2018
2 tasks
BlackyTay pushed a commit to BlackyTay/PhpSpreadsheet that referenced this pull request Aug 8, 2025
MS Excel skip non numeric values also. PhpSpreadsheet used to fail on string value with: Warning: A non-numeric value encountered.

Fixes  PHPOffice#618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants