Loop in ODS Reader#832
Closed
Krakozaber wants to merge 1 commit intoPHPOffice:developfrom
Krakozaber:patch-1
Closed
Loop in ODS Reader#832Krakozaber wants to merge 1 commit intoPHPOffice:developfrom Krakozaber:patch-1
Krakozaber wants to merge 1 commit intoPHPOffice:developfrom
Krakozaber:patch-1
Conversation
Fix loop in listWorksheetInfo()
Member
|
Could you please let us know what |
Contributor
Author
|
|
Member
|
That seems to be an invalid file. While your PR was merged, I'd recommend re-considering the tool you used to create the files in the first place. |
Contributor
Author
|
It's libre office 6 |
guillaume-ro-fr
pushed a commit
to guillaume-ro-fr/PhpSpreadsheet
that referenced
this pull request
Jun 12, 2019
According to the spec, http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1415588_253892949, a `<table:table-row>` can only ever contains a `<table:table-cell>` or a `<table:covered-table-cell>`, but it seems that some invalid files in the wild may contains something else. That would trigger an infinite loop. So instead we totally ignore the invalid content. Closes PHPOffice#832
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
According to the spec, http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1415588_253892949, a `<table:table-row>` can only ever contains a `<table:table-cell>` or a `<table:covered-table-cell>`, but it seems that some invalid files in the wild may contains something else. That would trigger an infinite loop. So instead we totally ignore the invalid content. Closes PHPOffice#832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix loop in listWorksheetInfo()
This is:
Checklist:
Why this change is needed?
Loop in listWorksheetInfo()