feat: formalize RQ operators - #2681
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
max-sixty
reviewed
Jun 1, 2023
max-sixty
left a comment
max-sixty
left a comment
Member
There was a problem hiding this comment.
Quite the refactor!
V impressive for the target-specific modules. Renders some of the upstream work with regex operators moot — probably I should have just used strings originally by dialect.
| let neg = l -> null | ||
| let not = l -> null | ||
|
|
||
| module postgres { |
Member
Author
|
Your work on regex inspired me a bit on how to organize this. So it was not moot :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #746
Changes are mostly internal, but could be exposed an extension interface, where extensions could provide
.prqlfiles visible to users and also RQ operator implementations that would implement custom RQ operators.